Trump, a Republican, will have the dubious honour of being the first person convicted of a felony to assume the presidency