Trends inevitably come in cycles, and now the Noughties craze for wearing shorts over tights is sneaking back into fashion. Katie Rosseinsky looks back at the sartorial mistakes she made earlier in life