As the Birmingham-born chocolate brand loses its royal warrant, Katie Rosseinsky presents the case against this iconic British treat