The cold case of Elizabeth Short has both horrified and gripped the nation for decades. Rhian Lubin revisits the case 78 years on