Most rooms 'enjoy memorable views of Edinburgh Castle or expansive views across the Firth of Forth'