Her devotion to Trump, as seen in adoring letters, has sparked concern among the secret service